fix MR comments

2020-07-24 10:24:20 +02:00
parent aa914102d1
commit 970b53d4ef
2 changed files with 15 additions and 17 deletions
--- a/app/models/concerns/amendmenable.rb
+++ b/app/models/concerns/amendmenable.rb
@@ -5,14 +5,15 @@ module Amendmenable
    include ActiveStorageSupport::SupportForBase64

    has_one_base64_attached :amendment_signature
+
+    with_options on: :amendment do
+      validates :amendment_signer_name, presence: true
+      validates :amendment_signature, attached: true
+    end
  end

  def amendment_signable?
-    if contract_template.present?
-      contract_template.amendment_clause.present?
-    else
-      false
-    end
+    contract_template.present? && contract_template.amendment_clause.present?
  end

  def amendment_signed?