Upstream sync

spec/factories/contract_templates.rb

@@ -28,6 +28,10 @@ FactoryBot.define do
       release_type "material" 
     end
 
+    factory :misc_release_contract_template do
+      release_type "misc" 
+    end
+
     factory :location_release_contract_template do
       release_type "location" 
     end

spec/factories/misc_releases.rb

@@ -0,0 +1,47 @@
+FactoryBot.define do
+  factory :misc_release do
+    association :project
+
+    person_first_name "Jane"
+    person_last_name "Doe"
+
+    photos [Rack::Test::UploadedFile.new(Rails.root.join("spec", "fixtures", "files", "person_photo.png"), "image/png")]
+
+    trait :native do
+      person_phone "123-555-6789"
+
+      signature do
+        path = Rails.root.join("spec", "fixtures", "files", "signature.png")
+        Rack::Test::UploadedFile.new(path, "image/png")
+      end
+    end
+
+    trait :minor do
+      minor true
+      guardian_first_name "Jamie"
+      guardian_last_name "Doe"
+      guardian_phone "123-555-1234"
+    end
+
+    factory :misc_release_with_contract_template do
+      after(:build) do |misc_release, _|
+        misc_release.contract_template = build(:misc_release_contract_template)
+      end
+    end
+
+    factory :misc_release_with_contract_template_and_photos do
+      after(:build) do |misc_release, _|
+        misc_release.contract_template = build(:misc_release_contract_template)
+        path = Rails.root.join("spec", "fixtures", "files", "person_photo.png")
+        misc_release.photos.attach Rack::Test::UploadedFile.new(path, "image/png")
+      end
+    end
+
+    factory :misc_release_with_photo do
+      after(:build) do |misc_release, _|
+        path = Rails.root.join("spec", "fixtures", "files", "person_photo.png")
+        misc_release.photos.attach Rack::Test::UploadedFile.new(path, "image/png")
+      end
+    end
+  end
+end

spec/models/account_spec.rb

@@ -132,6 +132,7 @@ RSpec.describe Account do
         Account,
         ZoomMeeting,
         MedicalRelease,
+        MiscRelease,
         MatchingRequest
       ]
       Rails.application.eager_load!

spec/models/contract_template_spec.rb

@@ -14,6 +14,7 @@ describe ContractTemplate do
     it { is_expected.to have_many(:location_releases).dependent(:restrict_with_error) }
     it { is_expected.to have_many(:material_releases).dependent(:restrict_with_error) }
     it { is_expected.to have_many(:medical_releases).dependent(:restrict_with_error) }
+    it { is_expected.to have_many(:misc_releases).dependent(:restrict_with_error) }
   end
 
   describe 'validations' do

spec/models/misc_release_spec.rb

@@ -0,0 +1,53 @@
+require 'rails_helper'
+
+RSpec.describe MiscRelease, type: :model do
+  it_behaves_like "a contractable"
+  it_behaves_like "a notable"
+  it_behaves_like "a photoable"
+  it_behaves_like "a releasable"
+
+  describe "validations" do
+    it { is_expected.to validate_presence_of(:person_first_name) }
+    it { is_expected.to validate_presence_of(:person_last_name) }
+
+    context "for #person_email" do
+      it { is_expected.to allow_value("test@test.com", nil).for(:person_email) }
+      it { is_expected.not_to allow_values("foo", "test@foo", "N/A").for(:person_email) }
+    end
+
+    context "for native releases" do
+      it { is_expected.to validate_attachment_of(:signature).on(:native) }
+    end
+
+    context "for non-native releases" do
+      it { is_expected.to validate_attachment_of(:contract).on(:non_native) }
+    end
+  end
+
+  describe "attachments" do
+    it { is_expected.to respond_to(:signature) }
+  end
+
+  describe "#uses_edl?" do
+    it { is_expected.not_to be_uses_edl }
+  end
+
+  describe "#contract_file_name" do
+    it "includes project name, signed at date, release type, release number and person name" do
+      release = create(:misc_release_with_contract_template, id: 100, signed_at: Date.new(2020, 2, 10), person_first_name: "John", person_last_name: "Doe")
+
+      expect(release.contract_file_name).to eq("my-video-project_misc_2020.02.10_1_doe-john")
+    end
+
+    context "when signed at is nil" do
+      it "uses the created at date" do
+        release = create(:misc_release_with_contract_template, 
+                         signed_at: nil, 
+                         created_at: DateTime.new(2020, 2, 10, 12, 0, 0), 
+                         person_first_name: "John", person_last_name: "Doe")
+
+        expect(release.contract_file_name).to eq("my-video-project_misc_2020.02.10_1_doe-john")
+      end
+    end
+  end
+end

spec/models/project_spec.rb

@@ -10,6 +10,7 @@ RSpec.describe Project, type: :model do
     it { is_expected.to have_many(:music_releases).dependent(:destroy) }
     it { is_expected.to have_many(:talent_releases).dependent(:destroy) }
     it { is_expected.to have_many(:medical_releases).dependent(:destroy) }
+    it { is_expected.to have_many(:misc_releases).dependent(:destroy) }
     it { is_expected.to have_many(:videos).dependent(:destroy) }
     it { is_expected.to have_many(:contract_templates).dependent(:destroy) }
     it { is_expected.to have_many(:project_memberships).dependent(:destroy) }