Upstream sync

spec/controllers/api/medical_releases_controller_spec.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Api::MedicalReleasesController, type: :controller do
+  let(:current_user) { create(:user) }
+  let(:project) { create(:project, name: 'first', account: current_user.primary_account) }
+
+  describe '#index' do
+    it 'returns a succesful response' do
+      create(:medical_release, person_first_name: 'John', person_last_name: 'Lee', project_id: project.id)
+      create(:medical_release, person_first_name: 'Jane', person_last_name: 'Lee', project_id: project.id)
+
+      sign_in_to_api(current_user)
+      get :index, params: { project_id: project.id }
+
+      expect(response).to be_successful
+      expect(response.body).to include 'John'
+      expect(response.body).to include 'Jane'
+    end
+  end
+
+  describe '#show' do
+    it 'returns a succesful response' do
+      release1 = create(:medical_release, person_first_name: 'John', person_last_name: 'Lee', project_id: project.id)
+      release2 = create(:medical_release, person_first_name: 'Jane', person_last_name: 'Lee', project_id: project.id)
+
+      sign_in_to_api(current_user)
+      get :show, params: { id: release1 }
+
+      expect(response).to be_successful
+      expect(response.body).to include 'John'
+      expect(response.body).not_to include 'Jane'
+
+      get :show, params: { id: release2 }
+
+      expect(response).to be_successful
+      expect(response.body).not_to include 'John'
+      expect(response.body).to include 'Jane'
+    end
+  end
+end

spec/controllers/api/misc_releases_controller_spec.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Api::MiscReleasesController, type: :controller do
+  let(:current_user) { create(:user) }
+  let(:project) { create(:project, name: 'first', account: current_user.primary_account) }
+
+  describe '#index' do
+    it 'returns a succesful response' do
+      create(:misc_release, person_first_name: 'John', person_last_name: 'Lee', project_id: project.id)
+      create(:misc_release, person_first_name: 'Jane', person_last_name: 'Lee', project_id: project.id)
+
+      sign_in_to_api(current_user)
+      get :index, params: { project_id: project.id }
+
+      expect(response).to be_successful
+      expect(response.body).to include 'John'
+      expect(response.body).to include 'Jane'
+    end
+  end
+
+  describe '#show' do
+    it 'returns a succesful response' do
+      release1 = create(:misc_release, person_first_name: 'John', person_last_name: 'Lee', project_id: project.id)
+      release2 = create(:misc_release, person_first_name: 'Jane', person_last_name: 'Lee', project_id: project.id)
+
+      sign_in_to_api(current_user)
+      get :show, params: { id: release1 }
+
+      expect(response).to be_successful
+      expect(response.body).to include 'John'
+      expect(response.body).not_to include 'Jane'
+
+      get :show, params: { id: release2 }
+
+      expect(response).to be_successful
+      expect(response.body).not_to include 'John'
+      expect(response.body).to include 'Jane'
+    end
+  end
+end

spec/controllers/api/notes_controller_spec.rb

@@ -18,6 +18,14 @@ releases = [
   {
     type: :material_release,
     obligatory_attribute: :name
+  },
+  {
+    type: :medical_release,
+    obligatory_attribute: :person_name
+  },
+  {
+    type: :misc_release,
+    obligatory_attribute: :person_name
   }
 ]
 

spec/controllers/api/sync_controller_spec.rb

@@ -110,6 +110,26 @@ RSpec.describe Api::SyncController, type: :controller do
       expect(guardian_photo).to include('id', 'type', 'attributes')
       expect(photo_attributes).to include('filename', 'content_type', 'url', 'thumbnail_url')
     end
+
+    it 'contains misc releases' do
+      create_default_data
+
+      get :index
+
+      misc_releases = attributes_for_type('misc_releases')
+
+      expect(misc_releases.first).to include('id')
+    end
+
+    it 'contains misc releases' do
+      create_default_data
+
+      get :index
+
+      medical_releases = attributes_for_type('medical_releases')
+
+      expect(medical_releases.first).to include('id')
+    end
   end
 
   private
@@ -120,6 +140,8 @@ RSpec.describe Api::SyncController, type: :controller do
     create(:talent_release, project: project)
     create(:location_release, project: project)
     create(:material_release, project: project)
+    create(:medical_release, project: project)
+    create(:misc_release, project: project)
   end
 
   def create_default_data_with_guardian_info

spec/controllers/approvals_controller_spec.rb

@@ -0,0 +1,36 @@
+require "rails_helper"
+
+RSpec.describe ApprovalsController, type: :controller do
+  render_views
+
+  let(:user) { create(:user) }
+  let(:account) { user.primary_account }
+  let(:project) { create(:project, account: user.primary_account) }
+
+  before do
+    sign_in user
+  end
+
+  describe "#new" do
+    let!(:medical_release) { create(:medical_release, project: project) }
+
+    it "responds successfully" do
+      get :new, params: { medical_release_id: medical_release }
+
+      expect(response).to be_successful
+    end
+  end
+
+  describe "#create" do
+    it "changes approval status successfully" do
+      medical_release = create(:medical_release, project: project)
+
+      expect(MedicalRelease.last.approved?).to eq false
+
+      post :create, params: { medical_release_id: medical_release }
+
+      expect(response).to redirect_to [project, :medical_releases]
+      expect(MedicalRelease.last.approved?).to eq true
+    end
+  end
+end

spec/features/user_creates_task_request_spec.rb

@@ -21,7 +21,7 @@ RSpec.feature 'User creates task request', type: :feature do
     click_on 'Create Task request'
 
     expect(page).to have_content task_created_message
-    expect(page).to have_link("Done")
+    expect(page).to have_link("Back")
   end
 
   scenario 'user can view task request details' do

spec/features/user_managing_medical_releases_spec.rb

@@ -182,6 +182,18 @@ feature "User managing medical releases" do
       sign_in current_user
     end
 
+    scenario "Approved releases have checkmark and non-approved releases don't have checkmarks" do
+      create(:medical_release_with_contract_template, :native, project: project)
+
+      visit project_medical_releases_path(project)
+      expect(page).to have_css('i.fa.fa-check-circle.fa-2x', count: 0)
+
+      create(:medical_release_with_contract_template, :native, project: project, approved_by_user_email: "some@email.com", approved_at: DateTime.now)
+      visit project_medical_releases_path(project)
+
+      expect(page).to have_css('i.fa.fa-check-circle.fa-2x', count: 1)
+    end
+
     scenario "Download All is visible" do
       create(:medical_release_with_contract_template, :native, project: project)
       create(:medical_release_with_contract_template, :non_native, project: project)
@@ -200,6 +212,15 @@ feature "User managing medical releases" do
       expect(page).to have_link("Download", exact: true, count: 2)
     end
 
+    scenario "Review action in Manage menu is visible" do
+      create(:medical_release_with_contract_template, :native, project: project)
+      create(:medical_release_with_contract_template, :non_native, project: project)
+
+      visit project_medical_releases_path(project)
+
+      expect(page).to have_link(review_action, exact: true)
+    end
+
     scenario "Downloading PDF of native medical release is possible" do
       native_release = create(:medical_release_with_contract_template, :native, project: project)
 
@@ -208,6 +229,64 @@ feature "User managing medical releases" do
       click_link *view_release_pdf_link_for(native_release)
       expect(content_type).to eq('application/pdf')
     end
+
+    scenario "Reviewing release" do
+      create(:medical_release_with_contract_template, :native, project: project)
+
+      visit project_medical_releases_path(project)
+
+      click_link review_action
+
+      expect(page).to have_content review_page_heading
+      expect(page).to have_content approve_button
+    end
+
+    scenario 'When viewing the contract PDF of approved release there is page for office use only' do
+      medical_release = create(:medical_release_with_contract_template,
+                               :native,
+                               project: project,
+                               person_first_name: 'Jane',
+                               person_last_name: 'Doe',
+                               approved_by_user_name: "Big Joe",
+                               approved_by_user_email: "some@email.com",
+                               approved_at: DateTime.now)
+
+      sign_in(current_user)
+      visit project_medical_releases_path(project)
+      click_link *view_release_pdf_link_for(medical_release)
+
+      expect(content_type).to eq('application/pdf')
+      expect(content_disposition).to include('inline')
+      expect(pdf_body).to have_content for_office_use_only.upcase
+      expect(pdf_body).to have_content producer_label
+      expect(pdf_body).to have_content production_label
+      expect(pdf_body).to have_content employee_issued_to_label
+      expect(pdf_body).to have_content issued_by_label
+      expect(pdf_body).to have_content date_issued
+      expect(pdf_body).to have_content 'Big Joe'
+    end
+
+    scenario 'When viewing the contract PDF of not approved release there is no page for office use only' do
+      medical_release = create(:medical_release_with_contract_template,
+                               :native,
+                               project: project,
+                               person_first_name: 'Jane',
+                               person_last_name: 'Doe')
+
+      sign_in(current_user)
+      visit project_medical_releases_path(project)
+      click_link *view_release_pdf_link_for(medical_release)
+
+      expect(content_type).to eq('application/pdf')
+      expect(content_disposition).to include('inline')
+      expect(pdf_body).not_to have_content for_office_use_only.upcase
+      expect(pdf_body).not_to have_content producer_label
+      expect(pdf_body).not_to have_content production_label
+      expect(pdf_body).not_to have_content employee_issued_to_label
+      expect(pdf_body).not_to have_content issued_by_label
+      expect(pdf_body).not_to have_content date_issued
+      expect(pdf_body).not_to have_content 'Big Joe'
+    end
   end
 
   context "when the user is manager(project manager)" do
@@ -235,6 +314,15 @@ feature "User managing medical releases" do
       expect(page).to have_link("Download", exact: true, count: 0)
     end
 
+    scenario "Review action in Manage menu is not visible" do
+      create(:medical_release_with_contract_template, :native, project: project)
+      create(:medical_release_with_contract_template, :non_native, project: project)
+
+      visit project_medical_releases_path(project)
+
+      expect(page).not_to have_link(review_action, exact: true)
+    end
+
     scenario "Downloading PDF of native medical release is not possible" do
       native_release = create(:medical_release_with_contract_template, :native, project: project)
 
@@ -279,6 +367,15 @@ feature "User managing medical releases" do
       expect(page).to have_link("Download", exact: true, count: 0)
     end
 
+    scenario "Review action in Manage menu is not visible" do
+      create(:medical_release_with_contract_template, :native, project: project)
+      create(:medical_release_with_contract_template, :non_native, project: project)
+
+      visit project_medical_releases_path(project)
+
+      expect(page).not_to have_link(review_action, exact: true)
+    end
+
     scenario "Downloading PDF of native medical release is not possible" do
       native_release = create(:medical_release_with_contract_template, :native, project: project)
 
@@ -458,4 +555,40 @@ feature "User managing medical releases" do
   def dummy_signature_legal_text
     'Some signature legal language'
   end
+
+  def review_action
+    t 'medical_releases.medical_release.actions.review'
+  end
+
+  def review_page_heading
+    t 'approvals.new.heading'
+  end
+
+  def approve_button
+    t 'approvals.new.actions.approve'
+  end
+
+  def for_office_use_only
+    t 'contracts.for_office_use_only.heading'
+  end
+
+  def producer_label
+    t 'contracts.for_office_use_only.description_labels.producer'
+  end
+
+  def production_label
+    t 'contracts.for_office_use_only.description_labels.production'
+  end
+
+  def employee_issued_to_label
+    t 'contracts.for_office_use_only.description_labels.employee_issued_to'
+  end
+
+  def issued_by_label
+    t 'contracts.for_office_use_only.description_labels.issued_by'
+  end
+
+  def date_issued
+    t 'contracts.for_office_use_only.description_labels.date_issued'
+  end
 end