Upstream sync

spec/controllers/misc_releases_controller_spec.rb

@@ -0,0 +1,116 @@
+require "rails_helper"
+
+RSpec.describe MiscReleasesController, type: :controller do
+  render_views
+
+  let(:user) { create(:user) }
+  let(:account) { user.primary_account } 
+  let(:project) { create(:project, account: user.primary_account) }
+
+  before do
+    sign_in user
+  end
+
+  describe "#index" do
+    it "responds successfully" do
+      get :index, params: { project_id: project }
+
+      expect(response).to be_successful
+    end
+
+    it "renders content" do
+      release = create(:misc_release, project: project,
+                                        person_first_name: "My",
+                                        person_last_name: "Release", 
+                                        person_phone: "5551234567", 
+                                        person_email: "jane.doe@test.com")
+      create(:note, notable: release, content: "Some notes here")
+
+      get :index, params: { project_id: project }
+
+      expect(response.body).to have_content "My Release"
+      expect(response.body).to have_content "P: 5551234567"
+      expect(response.body).to have_content "jane.doe@test.com"
+      expect(response.body).to have_content "Some notes here"
+      expect(response.body).to have_content "Manage"
+    end
+
+    context "when there are no misc releases" do
+      it "renders an empty message" do
+        get :index, params: { project_id: project }
+
+        expect(response.body).to have_content("Misc Releases will appear here")
+      end
+    end
+
+    context "when there are many records" do
+      it "paginates the table" do
+        create_list(:misc_release, 20, project: project)
+
+        get :index, params: { project_id: project }
+
+        expect(response.body).to have_link("2", href: project_misc_releases_path(project, page: 2))
+      end
+    end
+
+    context "for xhr request" do
+      it "filters the releases by a query param" do
+        misc_releases = [
+          create(:misc_release, person_name: "Adam Sandler", project: project),
+          create(:misc_release, person_name: "Zoe Perry", project: project),
+        ]
+
+        get :index, params: { project_id: project, query: "Zoe" }, xhr: true
+
+        expect(response.body).not_to have_content("Adam Sandler")
+        expect(response.body).to have_content("Zoe Perry")
+      end
+    end
+  end
+
+  describe "#destroy" do
+    let!(:misc_release) { create(:misc_release, project: project) }
+
+    it "responds with redirect" do
+      delete :destroy, params: { project_id: project, id: misc_release }
+
+      expect(response).to be_redirect
+      expect(response).to redirect_to [project, :misc_releases]
+    end
+
+    it "sets the flash" do
+      delete :destroy, params: { project_id: project, id: misc_release }
+
+      expect(flash.alert).not_to be_nil
+    end
+
+    it "destroys the record" do
+      expect {
+        delete :destroy, params: { project_id: project, id: misc_release }
+      }.to change(MiscRelease, :count).by(-1)
+    end
+  end
+
+  private
+
+  def misc_release_params
+    attributes_for(:misc_release).merge(exploitable_rights_params)
+  end
+
+  def minor_misc_release_params
+    attributes_for(:misc_release, :minor_with_guardian_photo).merge(exploitable_rights_params)
+  end
+
+  def exploitable_rights_params
+    {
+      applicable_medium_id: ApplicableMedium.last.id,
+      applicable_medium_text: "applicable_media",
+      territory_id: Territory.last.id,
+      territory_text: "territory",
+      term_id: Term.last.id,
+      term_text: "term",
+      restriction_id: Restriction.last.id,
+      restriction_text: "restrictions",
+    }
+  end
+end

spec/factories/misc_releases.rb

@@ -23,6 +23,17 @@ FactoryBot.define do
       guardian_phone "123-555-1234"
     end
 
+    trait :minor_with_guardian_photo do
+      minor true
+      guardian_first_name "Jamie"
+      guardian_last_name "Doe"
+      guardian_phone "123-555-1234"
+      guardian_photo do
+        path = Rails.root.join("spec", "fixtures", "files", "pratt.jpg")
+        Rack::Test::UploadedFile.new(path, "image/jpeg")
+      end
+    end
+
     factory :misc_release_with_contract_template do
       after(:build) do |misc_release, _|
         misc_release.contract_template = build(:misc_release_contract_template)

spec/features/user_creates_note_spec.rb

@@ -109,4 +109,10 @@ feature "User creates notes" do
 
     it_behaves_like "a notable collection UI"
   end
+
+  context "for misc releases" do
+    subject! { create(:misc_release, project: project, notes: []) }
+
+    it_behaves_like "a notable collection UI"
+  end
 end

spec/features/user_creates_tags_spec.rb

@@ -92,4 +92,10 @@ feature "User creates tags" do
 
     it_behaves_like "a taggable collection UI"
   end
+
+  context "for misc releases" do
+    subject! { create(:misc_release, project: project, tags: []) }
+
+    it_behaves_like "a taggable collection UI"
+  end
 end

spec/features/user_managing_appearance_releases_spec.rb

@@ -72,6 +72,61 @@ feature 'User managing appearance releases' do
 
       expect(page).to have_content(successful_submission_message)
     end
+
+    scenario 'creating a release for a minor with two guardians', js: true do
+      allow(BrayniacAI::Validation).to receive(:create).and_return(double(:validation, valid: true))
+
+      project = create(:project, members: current_user, account: current_user.primary_account)
+      contract_template = create(:contract_template, project: project)
+
+      visit new_account_project_contract_template_appearance_release_path(project.account, project, contract_template)
+
+      expect(page).to have_photo_button
+      expect(page).not_to have_content('SECOND GUARDIAN INFORMATION')
+      expect(page).not_to have_content('SECOND GUARDIAN PHOTO')
+
+      page.check person_is_minor_checkbox
+      expect(page).to have_content('GUARDIAN INFORMATION')
+      expect(page).to have_content('GUARDIAN PHOTO')
+      expect(page).to have_content 'Guardian Email'
+
+      expect(page).to have_content 'SECOND GUARDIAN INFORMATION'
+      expect(page).to have_content 'SECOND GUARDIAN PHOTO'
+      expect(page).to have_content 'Guardian 2 Email'
+      expect(page).to have_content 'Guardian 2 Phone'
+      expect(page).to have_content 'Guardian 2 Address'
+
+      fill_in guardian_first_name_field, with: 'Guardian'
+      fill_in guardian_last_name_field, with: 'Name'
+      fill_in guardian_phone_field, with: '001101'
+      fill_in person_first_name_field, with: 'Jane'
+      fill_in person_last_name_field, with: 'Doe'
+      fill_in_person_address_fields
+      fill_in person_phone_field, with: '555-555-5555'
+      fill_in person_email_field, with: 'jane.doe@test.com'
+      fill_in person_date_of_birth, with: '01/01/1999'
+      attach_file person_photo_field, file_fixture('person_photo.png'), visible: :all
+      attach_file guardian_photo_field, file_fixture('hemsworth.jpeg'), visible: :all
+      draw_signature file_fixture('signature.png'), 'appearance_release_signature_base64'
+
+      fill_in guardian_email_field, with: 'invalid@email'
+      click_button submit_release_button
+      expect(page).to have_content('Guardian email is not an email')
+
+      fill_in guardian_email_field, with: 'valid@email.com'
+      fill_in_guardian_address_fields
+      attach_file guardian_photo_field, file_fixture('hemsworth.jpeg'), visible: :all
+      draw_signature file_fixture('signature.png'), 'appearance_release_signature_base64'
+
+      fill_in guardian_2_first_name_field, with: 'Second'
+      fill_in guardian_2_last_name_field, with: 'Guardian'
+      fill_in guardian_2_phone_field, with: '999'
+
+      click_button submit_release_button
+
+      expect(page).to have_content(successful_submission_message)
+      expect(AppearanceRelease.last.guardian_2_first_name).to eq 'Second'
+    end
   end
 
   context 'when signed in' do
@@ -454,6 +509,18 @@ feature 'User managing appearance releases' do
     'appearance_release_minor'
   end
 
+  def guardian_2_first_name_field
+    'Guardian 2 first name'
+  end
+
+  def guardian_2_last_name_field
+    'Guardian 2 last name'
+  end
+
+  def guardian_2_phone_field
+    'Guardian 2 phone'
+  end
+
   def guardian_first_name_field
     'Guardian first name'
   end

spec/features/user_managing_misc_releases_spec.rb

@@ -0,0 +1,55 @@
+require "rails_helper"
+
+feature "User managing misc releases" do
+  let(:current_user) { create(:user) }
+  let(:project) { create(:project, members: current_user, account: current_user.primary_account) }
+
+  context "when signed in as account manager" do
+    before do
+      sign_in current_user
+    end
+
+    scenario "Download All is visible" do
+      create(:misc_release_with_contract_template, :native, project: project)
+
+      visit project_misc_releases_path(project)
+
+      expect(page).to have_content download_all_button
+    end
+
+    scenario "Downloading PDF of native misc release is possible" do
+      native_release = create(:misc_release_with_contract_template, :native, project: project)
+
+      visit project_misc_releases_path(project)
+
+      click_link *view_release_pdf_link_for(native_release)
+      expect(content_type).to eq('application/pdf')
+    end
+  end
+
+  context "when the user is manager(project manager)" do
+    let(:current_user) { create(:user, :manager) }
+
+    before do
+      sign_in current_user
+    end
+
+    scenario "Download action in Manage menu is not visible" do
+      create(:misc_release_with_contract_template, :native, project: project)
+
+      visit project_misc_releases_path(project)
+
+      expect(page).to have_link("Download", exact: true, count: 0)
+    end
+  end
+
+  private
+
+  def download_all_button
+    'Download All'
+  end
+
+  def view_release_pdf_link_for(release)
+    ['Download', href: misc_release_contracts_path(release, format: 'pdf')]
+  end
+end

spec/lib/zoom_gateway_spec.rb

@@ -5,6 +5,7 @@ RSpec.describe ZoomGateway do
   let(:host_user_hash) { {"email" => "user1@directme", "id" => "host_user_id"} }
   let(:roles_members_response) { {"members" => [host_user_hash]} }
   let(:user_create_response) { {"id" => "new_host_id"} }
+  let(:user_settings_update_response) { "User settings updated" }
   let(:roles_assign_response) { {"ids" => ["new_host_id"]} }
   let(:meeting_hash) { {"id" => "meeting_id", "start_url" => "https://start_url", "join_url" => "https://join_url"} }
   let(:gateway) { ZoomGateway.new }
@@ -121,7 +122,9 @@ RSpec.describe ZoomGateway do
     it "returns new host id" do
       allow_any_instance_of(Zoom.new.class).to receive(:user_create).and_return(user_create_response)
       allow_any_instance_of(Zoom.new.class).to receive(:roles_assign).and_return(roles_assign_response)
+      allow_any_instance_of(Zoom.new.class).to receive(:user_settings_update).and_return(user_settings_update_response)
 
+      expect_any_instance_of(Zoom.new.class).to receive(:user_settings_update)
       expect(gateway.create_host("host-email@address")).to eq("new_host_id")
     end
 

spec/lib/zoom_wrapper_monkeypatch_spec.rb

@@ -0,0 +1,60 @@
+require 'rails_helper'
+
+RSpec.describe Zoom::Actions::User do
+  let(:wrapper) { Zoom.new }
+
+  describe '.update_user_settings' do
+    it 'raises exception if id param is missing' do
+      params = {
+        in_meeting: {
+          not_allowed_param: 1
+        }
+      }
+
+      expect do
+        wrapper.user_settings_update(params)
+      end.to raise_exception(Zoom::ParameterMissing)
+    end
+
+    it 'raises exception if not allowed param is present' do
+      params = {
+        id: 'dw3-3sd33',
+        in_meeting: {
+          not_allowed_param: 1
+        }
+      }
+
+      expect do
+        wrapper.user_settings_update(params)
+      end.to raise_exception(Zoom::ParameterNotPermitted)
+    end
+
+    it 'sends PATCH request to the Zoom API endpoint' do
+      params = {
+        id: 'zoom-120-id',
+        in_meeting: {
+          auto_saving_chat: true,
+          co_host: true,
+          non_verbal_feedback: true,
+          breakout_room: true,
+          group_hd: true,
+          far_end_camera_control: true,
+          allow_live_streaming: true
+        }
+      }
+
+      allow(Zoom::Utils).to receive(:parse_response).and_return 'Success!'
+
+      path = "/users/#{params[:id]}/settings"
+      body_params = { body: params.except(:id).to_json }
+      allow(wrapper.class)
+        .to receive(:patch)
+        .with(path, hash_including(body_params))
+        .and_return({})
+
+      mock_response = wrapper.user_settings_update params
+      expect(mock_response).to eq 'Success!'
+    end
+  end
+
+end

spec/policies/misc_release_policy_spec.rb

@@ -0,0 +1,33 @@
+require "rails_helper"
+
+describe MiscReleasePolicy do
+  let(:user_context) { build(:user_context) }
+
+  subject { described_class }
+
+  permissions :create? do
+    it { is_expected.to permit(:create) }
+  end
+
+  permissions :show? do
+    it { is_expected.to permit(:show) }
+  end
+
+  permissions :update? do
+    context "for a native release" do
+      it { is_expected.not_to permit(user_context, build(:misc_release, :native)) }
+    end
+  end
+
+  permissions :destroy? do
+    it { is_expected.to permit(:destroy) }
+  end
+
+  permissions :edit_photos? do
+    it { is_expected.to permit(:edit_photos) }
+  end
+
+  permissions :update_photos? do
+    it { is_expected.to permit(:update_photos) }
+  end
+end