Upstream sync

spec/features/user_manages_contract_templates_spec.rb

@@ -5,6 +5,7 @@ require 'rails_helper'
 RSpec.feature 'User manages contract templates', type: :feature do
   let(:current_user) { create(:user, :manager) }
   let(:project) { create(:project, members: current_user, account: current_user.primary_account) }
+  let(:project2) { create(:project, members: current_user, account: current_user.primary_account, name: 'New project') }
 
   before do
     sign_in(current_user)
@@ -191,6 +192,21 @@ RSpec.feature 'User manages contract templates', type: :feature do
     expect(page).not_to have_content('Test template')
   end
 
+  scenario 'archived contract templates from other projects are not shown when importing contract templates' do
+    create(:contract_template, :archived, project: project2, name: 'Archived template')
+    create(:contract_template, project: project2, name: 'Active template')
+    create(:contract_template, project: project)
+
+    visit project_contract_templates_path(project)
+    expect(page).to have_content('Test template')
+
+    click_on import_template_button
+
+    expect(page).not_to have_content('Test template')
+    expect(page).not_to have_content('Archived template')
+    expect(page).to have_content('Active template')
+  end
+
   context 'When the user is associate' do
     let(:current_user) { create(:user, :associate) }
 
@@ -198,7 +214,7 @@ RSpec.feature 'User manages contract templates', type: :feature do
       visit project_contract_templates_path(project)
 
       expect(page).not_to have_content('Create New Release Template')
-      expect(page).not_to have_content('Import Release Template')
+      expect(page).not_to have_content(import_template_button)
       expect(page).not_to have_content('Delete')
     end
   end
@@ -218,6 +234,14 @@ RSpec.feature 'User manages contract templates', type: :feature do
 
   private
 
+  def import_template_button
+    t 'contract_templates.index.actions.import'
+  end
+
+  def import_selected_templates_button
+    t 'release_template_imports.new.actions.import'
+  end
+
   def preview_heading
     t 'blank_contracts.new.preview_heading'
   end

spec/features/user_managing_appearance_releases_spec.rb

@@ -65,6 +65,8 @@ feature 'User managing appearance releases' do
       expect(page).to have_content('Guardian email is not an email')
 
       fill_in guardian_email_field, with: 'valid@email.com'
+      fill_in guardian_address_field, with: '123 Test Lane, New York, NY 10000'
+      attach_file guardian_photo_field, file_fixture('hemsworth.jpeg'), visible: :all
       draw_signature file_fixture('signature.png'), 'appearance_release_signature_base64'
       click_button submit_release_button
 
@@ -468,6 +470,10 @@ feature 'User managing appearance releases' do
     'Guardian email'
   end
 
+  def guardian_address_field
+    'Guardian address'
+  end
+
   def guardian_photo_field
     'appearance_release[guardian_photo]'
   end

spec/features/user_managing_broadcasts_spec.rb

@@ -40,12 +40,12 @@ feature "User managing broadcasts" do
     scenario "visit show page of broadcast", js: true do
       broadcast = create(:broadcast, :with_stream, :with_files, project: project)
       recording = create(:broadcast_recording, broadcast: broadcast)
-      
+
       visit project_broadcast_path(project, broadcast)
 
       expect(page).to have_content("Live stream is waiting to begin.")
       expect(page).to have_content("Copy URL")
-      
+
       within "#files" do
         expect(page).to have_content("contract.pdf")
       end
@@ -54,6 +54,17 @@ feature "User managing broadcasts" do
       expect(page).to have_content(recording.download_file_name)
     end
 
+    scenario "form will not submit if user clicks Add files without selected files", js: true do
+      broadcast = create(:broadcast, :with_stream, :with_files, project: project)
+
+      visit project_broadcast_path(project, broadcast)
+
+      expect(page).to have_content("Live stream is waiting to begin.")
+      expect(page).to have_content add_file_button
+
+      click_on add_file_button
+    end
+
     scenario "visit multi-view broadcast page", js: true do
       broadcast_one = create(:broadcast, :with_stream, :with_files, name: "Broadcast 1", project: project)
       broadcast_two = create(:broadcast, :with_stream, :with_files, name: "Broadcast 2", project: project)
@@ -80,8 +91,13 @@ feature "User managing broadcasts" do
     end
   end
 
+
   private
 
+  def add_file_button
+    'Add File'
+  end
+
   def broadcast_name_field
     "broadcast[name]"
   end