senaduka/old-crm-integration
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix member practice summary report

Browse Source
This commit is contained in:
Senad Uka
2019-10-07 11:45:29 +02:00
parent 790b72f764
commit 602067e868
1 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
services/integration/reports.js
View File

@@ -503,15 +503,29 @@ const getMemberPracticeSummaryReport = (year) => {
const inactiveMemberIdsList = []; const inactiveMemberIdsList = [];
memberIdsListFromReportMap.forEach((memberId) => { memberIdsListFromReportMap.forEach((memberId) => {
if (membersMap[memberId].active){ if (memberId){
activeMemberIdsList.push(memberId); if (membersMap[memberId] && membersMap[memberId].active){
activeMemberIdsList.push(memberId);
}else{
console.log('[Get Member Practice Summary Report] Unknown member ');
console.log('\tmemberId : ', memberId);
console.log('\tmembersMap[memberId] : ', membersMap[memberId]);
inactiveMemberIdsList.push(memberId);
}
}else{ }else{
inactiveMemberIdsList.push(memberId); console.log('[Get Member Practice Summary Report] memberId is wrong : ', memberId);
} }
}); });
const sortMemberIdsListByName = (memberId1, memberId2) => { const sortMemberIdsListByName = (memberId1, memberId2) => {
if (membersMap[memberId1].name > membersMap[memberId2].name){ const name1 = membersMap[memberId1] ? membersMap[memberId1].name || 'Unknown member' : null;
const name2 = membersMap[memberId2] ? membersMap[memberId2].name || 'Unknown member' : null;
if (!name1 || !name2){
return 0;
}
if (name1 > name2){
return 1; return 1;
}else{ }else{
return -1; return -1;